search

n01r / picongpu

PIConGPU - A particle-in-cell code for GPGPUs
http://picongpu.hzdr.de
Other
0 stars 0 forks source link

Topic attribute bound electrons #7

Closed n01r closed 9 years ago

n01r commented 9 years ago

Hey @ax3l and @psychocoderHPC again, This PR is the continuation of my previous PR #6 and is based on that branch. It changes the attribute chargeState to boundElectrons. Feel free to comment!

psychocoderHPC commented 9 years ago

A general question: I don't know if is plays any roll but is freeElectrons a more native attribute instead of boundElectrons? The advantage of freeElectrons is that for all neutral materials the default is zero.

n01r commented 9 years ago

@psychocoderHPC If you would rename it like that it is the same as chargeState just with a different name. That would be zero, too for all neutral materials. It is a bit more native than chargeState but as we agreed on before, boundElectrons can be extended easier to coding what energy states the bound electrons are actually in.

ax3l commented 9 years ago

FreeElectrons does not make sence since these e- are not associated with the ion any more. So no :)

psychocoderHPC commented 9 years ago

yes this make sense