Handle multiple key candidates, print undumped data, refactor code

[gquere]

Hello,

Hope this can help your projet!

Modifications:

• an option to handle multiple key candidates by chaining -k arguments, i.e. "-k abcd -k efgh -k ijkl" and trying each of them until one successfully decrypts the keychain
• re-enabled printing of data which are not dumped to disk, otherwise those are missed by users
• a lot of refactoring to improve readability of the script

Although I successfully tested on the few keychains I had, I might have broken a few things. You should consider adding unit/functional tests.

[getaaron]

Thanks for the PR

[gquere]

Should we delete all the commented hexdumps?

Might be sometimes useful to print hex data, although here the hexdump dependency is useless IMO and breaks things on my debian based system (no such import exists and there is no package named as such although I haven't searched more).

A simple ''.join('{:02x}'.format(data_byte) for data_byte in data) would surely do the trick.

[n0fate]

I will change a code for printing result soon.

2019. 5. 18. 오후 8:39, gquere notifications@github.com 작성:

Should we delete all the commented hexdumps? Might be sometimes useful to print hex data, although here the hexdump dependency is useless IMO and breaks things on my debian based system (no such import exists and there is no package named as such although I haven't searched more).

A simple ''.join('{:02x}'.format(data_byte) for data_byte in data)` would surely do the trick.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/n0fate/chainbreaker/pull/8?email_source=notifications&email_token=AANECFD55VXU26TYEBFWMN3PV7THDA5CNFSM4HN2CMR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWNAFY#issuecomment-493670423, or mute the thread https://github.com/notifications/unsubscribe-auth/AANECFFEFAOYLXKOM6JCUXTPV7THDANCNFSM4HN2CMRQ.

[gquere]

Hello,

Any plans to merge? I can change the PR a bit if there are missing things