search

n0k0m3 / revanced-build-template

Github Template for building Revanced
GNU General Public License v3.0
139 stars 155 forks source link

Running locally, script needs to assert JDK v17 minimum #12

Closed seefood closed 2 years ago

seefood commented 2 years ago

https://github.com/n0k0m3/revanced-build-template/blob/0863230567019ae4e78913867c14b3c018cfe031/build_revanced.sh#L69

check jkava --version and warn the user if JDK is too old. on my home Ubuntu, for instance, I had to upgrade to JDK17 and the headless version is not enough, it looks for AWT so it needs the full JDK.

if you want me to fork and PR, I can do it too, and fix up a pre-commit config on the way. LMK.

n0k0m3 commented 2 years ago

Feel free to make a PR

seefood commented 2 years ago

made PR #21