search

n0k0m3 / revanced-build-template

Github Template for building Revanced
GNU General Public License v3.0
139 stars 155 forks source link

Root version doesn't work #16

Open quyleanh opened 2 years ago

quyleanh commented 2 years ago

Whenever I install root version apk, the parsing problem error is thrown.

Could you please support for root version?

n0k0m3 commented 2 years ago

You need to mount the rooted apk, not install it

https://github.com/revanced/revanced-cli/blob/e1c7d1082a6946d1082c8744a1d0118c1a2263ea/src/main/kotlin/app/revanced/utils/adb/Constants.kt

Will add the guide on how to do it eventually

quyleanh commented 2 years ago

Looking forward to seeing your guide.

Lyceris-chan commented 2 years ago

Looking forward to seeing your guide.

do you have magisk? if so check my repo https://github.com/Lyceris-chan/revanced-builder/releases/tag/latest

you can just download and flash the module in the magisk manager and it should work just fine

quyleanh commented 2 years ago

@Lyceris-chan wonderful! Thank you very much. It's much easier now.

n0k0m3 commented 2 years ago

Update: for root apk I don't see a "good" (read: simple) solution for this. I can totally make a script that push and exec another script to mount the apk as root, but that'll add more steps to the current setup for root people. (while it's just adb push and adb shell it's still a little bit too many steps) @Lyceris-chan do you mind making a PR for the action that build magisk module from your repo here?

Lyceris-chan commented 2 years ago

@n0k0m3 I think it might be better if you turn my magisk module into a template without my stuff and link it to the readme this way people can make their own module and they can make pull requests for updates and other stuff.

quyleanh commented 2 years ago

@n0k0m3 how about separate the current script to 2 scripts, which supports mount for root devices?

n0k0m3 commented 2 years ago

I don't have a plan for that as the idea of this repo is build and install from your own phone without a PC. Thus building a magisk module would make the most sense. I'll checkout on how to make a magisk module that replace system apps by mounting then gonna go back and work on this

n0k0m3 commented 2 years ago

@Lyceris-chan is it required that the unmount process must be run in post-fs-data mode?

Lyceris-chan commented 2 years ago

@Lyceris-chan is it required that the unmount process must be run in post-fs-data mode?

just do what I said earlier