search

n0k0m3 / revanced-build-template

Github Template for building Revanced
GNU General Public License v3.0
138 stars 151 forks source link

add a standard editorconfig, Java check, clean function #21

Closed seefood closed 2 years ago

n0k0m3 commented 2 years ago

I've seen fail compilation with JDK > 17 on discord, did you test with JDK 18 and confirm it works?

seefood commented 2 years ago

truth be told, I have only tried with Java11 (Ubuntu default) and 17. This bit may need more research.

seefood commented 2 years ago

java check removed.

n0k0m3 commented 2 years ago

Can you add a .gitignore for editorconfig?

seefood commented 2 years ago

Sure, I just don't see what a difference would it make now that it is a tracked file anyway.On 5 Jul 2022 17:41, n0k0m3 @.***> wrote: Can you add a .gitignore for editorconfig?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>