search

n0k0m3 / revanced-build-template

Github Template for building Revanced
GNU General Public License v3.0
138 stars 151 forks source link

feat: Use separate file for excluding patches #27

Closed ManorSailor closed 2 years ago

ManorSailor commented 2 years ago

This has been thoroughly tested & no inconsistencies were found in the tests. All the tests were performed using github actions on a private template of this repository. Generated apks were also tested on android device & they worked just fine. Despite of all this, if you find any inconsistencies, do let me know!

I haven't had the time to update readme, although, I have tried my best to include proper instructions in patches file.

Signing off, Sars.

Edit: Squashed commits

n0k0m3 commented 2 years ago

This is clean, thanks for the PR

ManorSailor commented 2 years ago

@n0k0m3 Btw, readme will need an update to reflect the current changes

n0k0m3 commented 2 years ago

Best way to do this is turn your patches.txt to a markdown file, replace with an empty patches.txt + .gitignore entry. This will allows update PRs when revanced team add new patches while minimizing merge/fetch from upstream conflicts

ManorSailor commented 2 years ago

Best way to do this is turn your patches.txt to a markdown file, replace with an empty patches.txt + .gitignore entry. This will allows update PRs when revanced team add new patches while minimizing merge/fetch from upstream conflicts

Quite neat! I didn't think of that, I learned something new today. On a side note, script will have to be updated. Although, not updating it will not break anything for now. I will do that tomorrow morning Edit: Just noticed, its not required.