search

n0k0m3 / revanced-build-template

Github Template for building Revanced
GNU General Public License v3.0
139 stars 155 forks source link

fix: Patches breaking due to blank characters #48

Closed ManorSailor closed 1 year ago

ManorSailor commented 2 years ago

Apparently, blank characters were causing the script to break. If any user added a whitespace or tab after adding patches in patches.txt, it was counted as a valid patch because our grep regexp was only ignoring hashes & not whitespace & tabs. I am quite surprised we didn't catch this before. Anyway, regexp has been modified to ignore blank characters as well as hashes.

Now users can fill the patches.txt with blank characters as much as they want without their scrip breaking

Closes #46

ronin08 commented 2 years ago

this is too much of a explanation. short-phrases will be better :)