search

n0mad01 / node.bittrex.api

No longer maintained
MIT License
183 stars 187 forks source link

error first callback #47

Closed oktapodia closed 7 years ago

oktapodia commented 7 years ago

Hello,

First, thanks for your library!

I saw something which breaks promisify and the bluebird.fromCallback

A lot of libraries follow the error first callback

I want to make a pull request about that, but I want first to know if it's something mergeable for you or not

Thanks by advance for your answer

dparlevliet commented 7 years ago

Yes, this is supported but not as standard for backward compatability reasons. Please see inverse_callback_arguments in https://github.com/n0mad01/node.bittrex.api#configure

oktapodia commented 7 years ago

Ok thanks for answer!