n0q / hackmaster5e-fvtt

A system for playing Hackmaster via Foundry Virtual Tabletop.
Apache License 2.0
7 stars 7 forks source link

Ranged Weapon Speed Calculation #304

Closed Smothmoth closed 6 months ago

Smothmoth commented 6 months ago

There seems to be something going wrong with the way total speed for ranged is being calculated at the moment. While setting up a new ranged weapon for an NPC boss, I notice that altering load/draw/aim/fire values manually gives very weird and seemingly random results as to what the new Total Speed value becomes.

n0q commented 6 months ago

That's interesting. Is it only happening with beasts? What sort of ranged weapon, and does the beast have a speed bonus? I'll try to reproduce this.

Smothmoth commented 6 months ago

It was a beast sheet yes. Was attempting to make a hand crossbow style weapon for a pirate boss, who does have a speed bonus. Though the weird behavior I'm noticing is on the attributes page for the item itself.

n0q commented 6 months ago

It looks like something rotten has snuck into the timing code, somewhere along the way. I'm able to reproduce this. Will make sure to get it done in the next release. Thanks for the report!

n0q commented 6 months ago

Seems like the sheet listener for this logic never actually worked correctly. You were observing the result of saving the new timing incorrectly, and then summing up the incorrect data. I can see how this would've looked random. This is resolved. It'll be fixed in the next update. Thanks again!

Smothmoth commented 6 months ago

Happy to be of help