search

n0v1c3 / vira

Create and update your Jira issues while inside Vim!
MIT License
95 stars 12 forks source link

Only use 'open' or 'xdg-open' if they are executable #42

Closed jamesl33 closed 4 years ago

jamesl33 commented 4 years ago

When using :ViraBrowse to open the current issue in the default browser Vira will only try to use 'open' or 'xdg-open' if they exist and are executable. This is a fallback for case where users have not provided 'g:vira_browser' or the 'BROWSER' environment variable.

Given a config/system where 'g:vira_browser' and 'BROWSER' are not set and 'open', 'xdg-open' are not executable, an informative error will be displayed asking the user to provide one of the two overriding variables.

When provided with a command via '$BROWSER' or 'g:vira_browser' that is not executable, :ViraBrowse will now display an informative error to the user.

n0v1c3 commented 4 years ago

@jamesl33 That looks exactly like what I was thinking with some nice extra clean wrapping around it. It will be a terminal pull again with a double check to try and find at least one thing I can make better then I will merge this into the next minor version push as I do not see it creating too many issue rather than solving them.

n0v1c3 commented 4 years ago

@jamesl33 that was a good one. I managed to find one thing to fix for now and it should give you a laugh. To the beginning we started with nvim as a part of the issue and this was all OS's and flexible code. The ViM user in me should have known from the start.

n0v1c3 commented 4 years ago

Also, to let you know the extra branches from me you have leftover are the initial wave of video branches and don't have too much other than the videos and links of us trying to show it works.