search

n0v1c3 / vira

Create and update your Jira issues while inside Vim!
MIT License
94 stars 12 forks source link

VIRA-276: Set default issue sort #65

Closed ghost closed 3 years ago

ghost commented 3 years ago

Issue sorting is required by further Jira queries but the userconfig_issuesort is set only when configuring a project based on vira_projects.json. If projects are not defined, missing, or whatever, then userconfig_issuesort is never set resulting in Jira query errors.

This commit sets a default sane value to require users as little configuration upfront as possible.

n0v1c3 commented 3 years ago

Hello @kkonopko I can see that you are making the list and checking it twice. I always appreciate feedback and especially pull requests like these ones. I will do a real review this evening for myself and get them merged into at least the dev branch and most likely the master branch after that.

Keep letting me know everything I can do better. Even if you don't have an answer for it right away the thoughts can be just as large as an impact, the db was not expected to go where it is going that is for sure.

n0v1c3 commented 3 years ago

I am going to merge them all together onto my branch then move them forward onto the dev branch in the process flow.

ghost commented 3 years ago

Hello @n0v1c3

Hello @kkonopko I can see that you are making the list and checking it twice. I always appreciate feedback and especially pull requests like these ones. I will do a real review this evening for myself and get them merged into at least the dev branch and most likely the master branch after that.

Thanks, no worries. Very readable and appealing project. I tend to have no time for contributing my fixes but this time it was a breeze.

Keep letting me know everything I can do better. Even if you don't have an answer for it right away the thoughts can be just as large as an impact, the db was not expected to go where it is going that is for sure.

I may be missing a bigger picture sometimes so I'm not expecting these PRs fit perfectly. Tried to come up with fixes as good as possible without overthinking it.

n0v1c3 commented 3 years ago

Your pull requests should be in my dev branch from the terminal level. I will do some testing today but have seen no issues to push them to master shortly.

The bigger picture is simply keep the ideas coming, VIRA will most likely grow larger than Jira alone as you may see from my one posted GitHub is next issue.

The db example started with lag, I developed added async and now is turning into a db much more than I would have expected to prevent some user lag. I do like the issues coming to me though as sometimes I just need to hear about other people's issues and not just my own.

This db is going to evolve my entire software most likely so it turned into not a small task just to prevent some lag. Funny how that can happen.