Clean up temp files on the way out

n10v / id3v2

🎵 ID3 decoding and encoding library for Go

https://pkg.go.dev/github.com/bogem/id3v2/v2

MIT License

339 stars 52 forks source link

Clean up temp files on the way out #10

Closed gabek closed 8 years ago

gabek commented 8 years ago

Looking to fix https://github.com/bogem/id3v2/issues/9.

gabek commented 8 years ago

As a golang newbie, I don't know if this is the right approach or not. Is checking for the existence, and closing the file handler of the tmp file needed?

mro commented 8 years ago

not sure about close (think it's superficial), I also wouldn't check existence, but rather just try to remove. Non-existence may point to rights or space issues, but that's a thing for the open to care about.

gabek commented 8 years ago

Great! Just simplified it down to only the removal.

n10v commented 8 years ago

Can you please accommodate all the changes of tag.go file in one commit?

gabek commented 8 years ago

No problem. Done.

n10v commented 8 years ago

Good. Thank you, @gabek!