leaving behing go < 1.7 ?

n10v / id3v2

🎵 ID3 decoding and encoding library for Go

https://pkg.go.dev/github.com/bogem/id3v2/v2

MIT License

334 stars 50 forks source link

leaving behing go < 1.7 ? #24

Closed mro closed 7 years ago

mro commented 7 years ago

somewhen between now and 14 days ago you dropped support for go 1.5 and 1.6. Is this by intention or accident?

Thx, m

(I'm using it in https://travis-ci.org/mro/internet-radio-recorder/builds/228106947)

n10v commented 7 years ago

Hi, @mro! Yes, I made it by intention to support only last two version of go. This is the only breaking change. If you really need to support older versions, I can restore it.

mro commented 7 years ago

actually backwards compatibility isn't a major issue and I was just wondering. Having it is nice, but only as long as it doesn't stand in the way.

n10v commented 7 years ago

It actually doesn't stand in the way. The only issue that breaks the compatibility is what I decided to use io.SeekStart instead of os.SEEK_SET here, so it's not the problem.