n10v / id3v2

🎵 ID3 decoding and encoding library for Go
https://pkg.go.dev/github.com/bogem/id3v2/v2
MIT License
339 stars 52 forks source link

add COMM and USLT #3

Closed mro closed 8 years ago

mro commented 8 years ago

you mentioned to add frames on request. For my internet recorder, I add the radio broadcast abstract both into COMM and USLT. In order to reduce the technology mix a bit and get rid of ruby it would be really neat to have a Go option.

Would you mind enabling them?

n10v commented 8 years ago

Ok, I will enable it either today or tomorrow

mro commented 8 years ago

no hurries. I may use it somewhen in the next months.

n10v commented 8 years ago

Anyway, I have nothing to do😅 So it will be realized soon

n10v commented 8 years ago

I added USLT and COMM frames. Instructions you can see in README. And please prove the work of these frames🙏

mro commented 8 years ago

I didn't forget about to test this, it will just still take some time.

n10v commented 8 years ago

Good :) There was one more update: I added documentation. Can you say, do you find it convenient to read?

mro commented 8 years ago

I just did a $ go get -u github.com/bogem/id3v2 and took a look at USLT and COMM. USLT makes it perfectly into iTunes while COMM doesn't show up – but that may well be a iTunes quirk.

So: I'm happy, thanks a lot for this lean library and thanks for your patience!

mro commented 8 years ago

btw. that's exactly the same with the ruby/c++ taglib approach in https://github.com/bogem/id3v2/issues/3#issue-157374256

mro commented 8 years ago

I added documentation. Can you say, do you find it convenient to read?

I'm maybe an unusual documentation-reader, I prefer it as lean as your library :-) The fewer, the better. Where I took how to use it, is the tests. They're all I care about, thanks a lot again!

n10v commented 8 years ago

My iTunes also doesn't see COMM frames. I hope, it's not because my lib doesn't work well 😂 Anyway, thanks for your offers! I'm always glad to hear new ones :)

mro commented 8 years ago

your lib is awesome, iTunes is a shame.

n10v commented 8 years ago

Thank you! Very nice to hear😌