n10v / id3v2

🎵 ID3 decoding and encoding library for Go
https://pkg.go.dev/github.com/bogem/id3v2/v2
MIT License
334 stars 50 forks source link

fix: updates PictureFrame sequencing to prevent unfortunate conflicts #66

Closed tillt closed 2 years ago

tillt commented 2 years ago

When the source file contains multiple APIC frames, with equal Descriptions, we will only use the first one. This is not really what we want. We want to use the first one matching this Description and PictureType.

This patch ensures that APIC frames of different PictureType will be considered unique even if the Description was not.

Updates sequencing tests accordingly. Seems I had to get a bit more verbose in the test coverage.

n10v commented 2 years ago

See v2.0.0 release