search

n10v / id3v2

🎵 ID3 decoding and encoding library for Go
https://pkg.go.dev/github.com/bogem/id3v2/v2
MIT License
339 stars 53 forks source link

Doesn't add PictureFrame to ogg formats! #80

Closed AYehia0 closed 1 year ago

AYehia0 commented 1 year ago

Thanks for the great package. It just works for all mp3 files, but when it comes to different formats, like ogg it adds everything except the PictureFrame, which is kinda weird.

...
    if imgBytes != nil {
        tag.AddAttachedPicture(
            id3v2.PictureFrame{
                Encoding:    id3v2.EncodingUTF8,
                MimeType:    "image/jpeg",
                Picture:     imgBytes,
                Description: track.SoundData.Description, // well, coz why not :D
            },
        )
    }
...
n10v commented 1 year ago

Hey @AYehia0! Thanks a lot for reporting this issue! Can you please send an OGG file where I can reproduce the issue?

AYehia0 commented 1 year ago

Thanks @bogem, I have tested the OGG/OPUS file and I found out that the issue is within the audio player itself, not the package :smile: Thank you for this great package, keep it up :D