n15g / badger

CoH Badge Tracker
GNU General Public License v3.0
5 stars 9 forks source link

Additional content-db bugs #28

Open PsiLupan opened 4 years ago

PsiLupan commented 4 years ago

I've recently created a fork of the Homecoming content db for Thunderspy and added it as a new content-db, which is visible at https://psilupan.github.io/badger/

I've noticed the following after adding the package and loading it via the following new lines in the content-db.service.ts constructor:

this.contentDb.load(new Thunderspy());
this.contentDb.load(new ThunderspyBadges());
this.contentDb.load(new ThunderspyChangelog());

The server shows under the Badges dropdown, but changing between Homecoming and Thunderspy leads to a filter based off the previous page. IE. Homecoming -> Thunderspy leads to a negative filter.

Likewise, attempting to create a new character leads to an invalid key error for loading the Archetype image data when looking at the console log. I'm unsure what the cause is here as break-pointing seems to indicate no serverGroup is available and the key is thus null, as the only line removed was that for Sentinel in the array.

PsiLupan commented 4 years ago

Just to verify, I loaded up without Homecoming loaded in the contentDB constructor, and everything works as expected.

n15g commented 4 years ago

There seems to be a few issues with multiple server groups... oversights since it's never really been implemented. I can't even test it locally because I'm getting some weird issue with the popper.js dropdown in the main menu. I'm a bit busy at the moment, but I'll try and get some time to look into these issues further as soon as I can.