search

n1k0 / tinysynth

A drums looper made with React and the WebAudio API
https://n1k0.github.io/tinysynth
249 stars 58 forks source link

Modularize components into separate files #14

Closed newyork-anthonyng closed 7 years ago

newyork-anthonyng commented 7 years ago

Great work on this! I'm loving the synth so far and would like to help with some of the issues you created.

I wanted to start off first by modularizing the components into their own files to make it easier to maintain. Let me know if there's anything you want me to change.

n1k0 commented 7 years ago

Oh, thanks! I'm working on a feature branch to have melodic voices where I've started doing such a modularization, check it out

n1k0 commented 7 years ago

I'm embarrassed as the new branch features a lot of UI improvement as well as a few bugfixes, but conflicts hard with your patch. I should have landed things more iteratively, sorry...

newyork-anthonyng commented 7 years ago

No problem. I'll take a look at synth-tracks branch and see what you've been working on.

-Anthony

On Sun, Nov 27, 2016 at 11:26 AM, Nicolas Perriault < notifications@github.com> wrote:

I'm embarrassed as the new branch features a lot of UI improvement as well as a few bugfixes, but conflicts hard with your patch. I should have landed things more iteratively, sorry...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n1k0/tinysynth/pull/14#issuecomment-263141447, or mute the thread https://github.com/notifications/unsubscribe-auth/ANYqSbfjQZ29J31dymztAPmwxqjn6i3Sks5rCdlggaJpZM4K9OYw .