search

n1ru4l / envelop

Envelop is a lightweight library allowing developers to easily develop, share, collaborate and extend their GraphQL execution layer. Envelop is the missing GraphQL plugin system.
https://envelop.dev
MIT License
777 stars 126 forks source link

Add Sentry v8 compatible integration #2193

Open gajus opened 5 months ago

gajus commented 5 months ago

Just flagging that the current plugins are not compatible with Sentry v8 SDK.

Some related context:

akabekobeko commented 3 months ago

It looks like need to migrate from startTransaction to startSpan, which was deprecated in Sentry v8.

ERR TypeError: Sentry.startTransaction is not a function
      at onExecute (.../node_modules/@envelop/sentry/cjs/index.js:48:35)
      at .../node_modules/graphql-yoga/node_modules/@envelop/core/cjs/orchestrator.js:360:37
bgentry commented 1 month ago

Related dep upgrade PR https://github.com/n1ru4l/envelop/pull/2235

Needs some manual work to get it over the line and adjust to the new APIs.

trixobird commented 1 month ago

jsut created a new PR #2277, with all the tests passing. I did add a @ts-expect-error though :'(

bastiankistner commented 1 month ago

@trixobird wonderful! Was just looking for this 👏

trixobird commented 4 weeks ago

@benjie, @n1ru4l is there anything else needs from my side to get this PR reviewed and hopefully merged? Apologies for the newbie question