search

n3-charts / line-chart

Awesome charts for AngularJS.
http://n3-charts.github.io/line-chart/
MIT License
1.2k stars 180 forks source link

Android touch support #527

Open wasper1 opened 7 years ago

wasper1 commented 7 years ago

Issue #527 The aim of this PR is to extend chart to support Android touch devices. I've tested this on: Android 4.4.2 Android 4.0.3

wasper1 commented 7 years ago

Please trigger CI again or change some configuration cause e2e tests failed on webdriver Error: ECONNREFUSED connect ECONNREFUSED

lorem--ipsum commented 7 years ago

Hi, thanks for the PR. Unfortunately I've been working on a big update (switching to TS2 and a different modules manager, mainly) and your PR will probably have to be updated. I'll help you through this if you want, though.

chaosmail commented 7 years ago

Thanks for the great contribution! I think this feature could be great for v2 as well. I fixed a couple of things, especially these bugs with travis in the latest PR, and merged the changes in your branch. I would not mind porting it to the new latest dev version, but maybe @wasper1 can help us out on this!

chaosmail commented 7 years ago

Nice travis is passing now! However, we should definitly have some e2e test on this feature.

chaosmail commented 7 years ago

Resolves #535

chaosmail commented 7 years ago

I moved the branch to feat/android-touch for now, so I can rebase on master and add some tests