n3-charts / line-chart

Awesome charts for AngularJS.
http://n3-charts.github.io/line-chart/
MIT License
1.2k stars 180 forks source link

Angular 2 Support #542

Open caJaeger opened 7 years ago

caJaeger commented 7 years ago

Is there any plan to support angular 2?

graham-sportsmgmt commented 7 years ago

Would love to see Angular support for this project, happy to help.

chaosmail commented 7 years ago

Hi guys, sorry for the late reply.

Yeah, we planned to pull out the core functionality and support multiple frameworks - we currently added alpha support for react in this repo, so angular >= 2 shouldn't be that difficult.

We basically have to implement the directive/component functionality like for Angular 1 (can be found here https://github.com/n3-charts/line-chart/tree/master/src/angularjs) that wraps the D3 chart. This should preferably be done in a seperate project, as all the dependencies will (most likely) collide with Angular 1.

I once tried to pull out only the core functionality in a separate prohject (https://github.com/n3-charts/line-chart-vanilla), but I somehow stopped working on this. In my opinion though this would be the best way to split the functionality.

Would be great if you ( @graham-sportsmgmt ) would implement/hack together a working demo/proof of concept with either this repo or the vanilla repo so that I can help you to integrate it to n3-charts.

Hope that helps!

Best, Christoph

graham-sportsmgmt commented 7 years ago

Excellent, I'm happy to proceed knowing that we have your support on this :) Many thanks!

I have just created a repository here to host the prototype:

https://github.com/sportsmgmt-labs/n3-next