n3bojs4 / octoprint-LCD1602

15 stars 12 forks source link

Version pinning #25

Open dbrgn opened 2 years ago

dbrgn commented 2 years ago

Hi, I'm the author of RPLCD. I don't actively use Octoprint, but stumbled upon this plugin through #23.

I saw that you do no version pinning at all in setup.py. RPLCD follows semantic versioning, meaning that a potential v2 release would contain breaking changes. While a v2 release of RPLCD is very unlikely, I'd still recommend to pin your versions. (I've had a lot of complaints when I switched from 0.x to 1.0 with some breaking changes, from downstream users of code that did not pin their dependencies.)

If I'm not mistaken, RPLCD~=1.3 should do the trick.