search

n3d1117 / appdb

A fully-featured iOS client for appdb.to written in Swift 5
MIT License
320 stars 43 forks source link

Search Bar Font Black on Grey in Dark Theme #34

Closed dtimekeeper closed 5 years ago

dtimekeeper commented 5 years ago

Search bar font remains black on grey when the Dark theme is used on V1.0.

(Amazing work on the app, super slick and the library/download along with the rest of the API integration is super well done). C828FCEA-5083-4E87-BC45-29EA27266124

n3d1117 commented 5 years ago

Hello! I can't seem to reproduce it. What device and iOS version are you on? Is the text still gray when you close and reopen the app?

dtimekeeper commented 5 years ago

Hi - I’m on an iPad Pro 11” running, uh, iOS13 Developer beta 1. Running the app theme in Light, Dark, and Darker, and on the iOS light and dark themes produce the same black on grey result. It persists when I force close the app and re-open.

I’m happy to test further if needed.

n3d1117 commented 5 years ago

Hmm so the text is always gray regardless of the theme (Light, Dark, Darker, iOS Light, iOS Dark) you use? Does it affect all the in-app search bars? Please check News and See All too.

It could be a specific bug in SwiftTheme library related to search bars in iOS 13. Sadly I don't have any iOS 13 devices to test this myself.

dtimekeeper commented 5 years ago

Yep, it's always grey regardless of what theme I use, and it's across all the search bars, both in the Search tab and the 'See all' popup. It probably is an ios13 specific bug in the theming library.

Thanks for checking into it and for creating the app.

On Wed, Jun 5, 2019 at 4:05 AM ned notifications@github.com wrote:

Hmm so the text is always gray regardless of the theme (Light, Dark, Darker, iOS Light, iOS Dark) you use? Does it affect all the in-app search bars? Please check News and See All too.

It could be a specific bug in SwiftTheme library https://github.com/wxxsw/SwiftTheme related to search bars in iOS 13. Sadly I don't have any iOS 13 devices to test this myself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n3d1117/appdb/issues/34?email_source=notifications&email_token=ABK3WG3AFD32ZSM2Q7X6KVDPY6MXDA5CNFSM4HTTC5KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7LXXY#issuecomment-499039199, or mute the thread https://github.com/notifications/unsubscribe-auth/ABK3WGZFO2KV4PJ22F7VS7LPY6MXDANCNFSM4HTTC5KA .

n3d1117 commented 5 years ago

@dtimekeeper I found the issue! It was my fault. Will be fixed in the next update!

greybaron commented 5 years ago

@n3d1117 on an iPad Pro 11", iOS 13 dev beta 4, appdb 1.0.1 (latest release) the search text is still black in the appdb dark mode. Only the "Search iOS Apps" text is light grey.

n3d1117 commented 5 years ago

Hello @greybaron, thanks for reporting. This might be fixed in 847a823 (don't have an iOS 13 device so I can't test). Could you try to install this test build and see if it's fixed? Thanks I'll reopen the issue for now.

greybaron commented 5 years ago

Sorry for the late reply. The issue is still present in the test build, tested on dev beta 5. "Search iOS Apps" looks good but the search text is black

n3d1117 commented 5 years ago

Ok @greybaron, thanks for reporting, seems like things changed a bit with iOS 13. Since I can't afford to update to a macOS beta, you'll have to wait until Xcode 11 and iOS 13 are publicly released for this to be fixed. I'll keep this issue open until then.

n3d1117 commented 5 years ago

Hi @greybaron @dtimekeeper, please test release 1.0.2! I was not able to reproduce this issue using latest version. Let me know! I will keep this open for now

dtimekeeper commented 5 years ago

@n3d1117 confirmed fixed for me on iOS 13.2 dev beta 2 and release 1.0.2. :)