n3m3sis00 / phylo-react

React component library for Phylogenetic Analysis
https://n3m3sis00.github.io/phylo-react/
1 stars 1 forks source link

Current tree rendering bug #26

Closed cmdcolin closed 3 years ago

cmdcolin commented 3 years ago

The current tree appears to have some visual weirdness

localhost_46307__path=_story_tree--complex-tree

cmdcolin commented 3 years ago

I think this goes back a fairly long ways, it may be particular to this tree. Might need investigation though

cmdcolin commented 3 years ago

It looks like this dataset just has invalid branch lengths maybe it renders incorrectly in this app as well http://etetoolkit.org/treeview/

cmdcolin commented 3 years ago

I suggest we remove this example from our data, if it is truly invalid

cmdcolin commented 3 years ago

This commit is a "stopper" that can sets length to 0 instead of negative

7f010ce this is suggested here https://www.biostars.org/p/45597/