search

n3m3sis00 / phylo-react

React component library for Phylogenetic Analysis
https://n3m3sis00.github.io/phylo-react/
1 stars 1 forks source link

Show branch length prop #30

Closed cmdcolin closed 3 years ago

cmdcolin commented 3 years ago

This is a refactoring that loses some functionality, the show branch length animation, however, I think it gains code clarity. I was unable to figure out how to keep the transitions and my feeling was that it might be better to have it like this for now sense it gains simplicity

If it is highly desirable to keep the animation, I could reconsider this, but I think that it is important to have the code behave properly

This also touches up the storybook docs a little bit

n3m3sis00 commented 3 years ago

@cmdcolin, Thanks for the pull request, It looks good :smile: