Enums - Githubissues

brettz9 commented 4 years ago

feat: Handle string enums as string literals
feat: process root for non-object/non-array types (nullable, multiple types)

Btw, I took a look at other forks to look for anything that might be useful. This looks like the one fork with some useful ideas (like a CLI) that might be nice to include (not on my priority list, but just an FYI): https://github.com/n3ps/json-schema-to-jsdoc/compare/master...cdmgtri:dev

n3ps commented 4 years ago

Yeah, a CLI might be handy. I think commander is good solution for this

brettz9 commented 4 years ago

Being a JSON guy, you might like command-line-args if you haven't seen it. Besides the more JSON-friendly API, I like the ecosystem around it (the last two are my own):

command-line-usage - For formatted help
command-line-publish - For printing SVG or HTML of the CLI-formatted help (e.g., to embed in one's README)
command-line-basics - A utility which bundles command-line-usage and update-notifier (to report to the user if their CL app is out of date) and adds -v and -h automatically.

No promises I'd implement, but just mentioning if that approach may be of interest and is I think pretty clean.

brettz9 commented 4 years ago

Thanks for the review/merge. Rebased!

n3ps / json-schema-to-jsdoc

Enums #30