search

n3rd4i / scrcpy

2 stars 5 forks source link

New App Icon #8

Open p-schneider opened 2 years ago

p-schneider commented 2 years ago

With Version 1.20 scrcpy now has a new icon -> Genymobile/scrcpy#1987 SVG: new icon (svg)

PNG: new icon (png)

So it looks like the scripts/generate-icon.ps1 file needs to be updated to reflect that change (instead of loading and converting the old xpm icon from version 1.18).

tech189 commented 2 years ago

@n3rd4i if you have time could you take a look at my PR which adds the new icon? It's quite a small change :)

p-schneider commented 2 years ago

With the 1.22 Release today an "official" .ico file was added to scrcpy: https://github.com/Genymobile/scrcpy/blob/master/data/icon.ico -> https://raw.githubusercontent.com/Genymobile/scrcpy/master/data/icon.ico (It was added in december, but I just read about it in the 1.22 changelog.)

/data/icon.ico: MS Windows icon resource - 1 icon, 256x256 with PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced, 32 bits/pixel

So with that it makes no sense to maintain scripts/generate-icon.ps1 here because the "official" icon.ico file should be good enough.