React Stars cleanup - Githubissues

n49 / react-stars

A simple star rating component for your React projects :star:

http://developers.n49.com/react-stars/

218 stars 81 forks source link

React Stars cleanup #25

Open kayluhb opened 7 years ago

kayluhb commented 7 years ago

Take advantage of React's defaultProps
Use props instead of state.config since state should only hold things that change
Fix validation issues with changing state on component mount
Fix prop-types import for React 16+
Don't use a cursor if when you cannot edit
Don't chain variable assignment
Don't reassign parameters
Don't bind methods in the render
Don't call methods when not editing
Add all propTypes to the propTypes declaration
Add a displayName attribute for easier debugging

olegberman commented 7 years ago

Thank you @kayluhb! Can you double check what happened to examples? This is what I am getting after building

olegberman commented 7 years ago

Apologies, that was my fault by running examples from local file://. That is fixed in e91448d09731. I checked out at your latest commit 9b4dfd9 I am getting an issue with half stars. You can try yourself (run npm run dev-example and try second example).

kayluhb commented 7 years ago

@olegberman rebased with master and fixed the issue. If I get a chance I'll submit a new PR for running some jest tests.