search

n49 / react-stars

A simple star rating component for your React projects :star:
http://developers.n49.com/react-stars/
218 stars 82 forks source link

use prop-types #30

Closed cescoferraro closed 6 years ago

ashleyrwharton commented 6 years ago

@cescoferraro - you've added a load of semicolons to the src file, can you remove them and just leave the PropTypes import line?

cescoferraro commented 6 years ago

@ashleyrwharton here it go

Kronuz commented 6 years ago

This pull request changes hell of a lot more than just PropTypes. Could it be possible to have a clean pull request with only React 16 ready changes instead please?

ashleyrwharton commented 6 years ago

@cescoferraro - you need to keep the semicolons in CSS strings, for loop params etc. Just remove the unnecessary ones at the end of statements