n49 / react-stars

A simple star rating component for your React projects :star:
http://developers.n49.com/react-stars/
218 stars 82 forks source link

User cannot change stars when edit property is passed as true #38

Closed anvk closed 6 years ago

anvk commented 6 years ago

How to setup test:

  1. Follow instructions provided in readme.
  2. Change one of the component configurations in /example/index.js to include edit: true E.g.
const secondExample = {
  size: 50,
  count: 10,
  char: '',
  edit: true, // Added this property
  color1: '#ff9900',
  color2: '#6599ff',
  onChange: newValue => {
    console.log(`Example 2: new value is ${newValue}`)
  }
}
  1. Run npm run dev-example and observe how the apple rater does not work anymore
olegberman commented 6 years ago

Thank you for your contribution, @anvk! :)

anvk commented 6 years ago

Np @olegberman . Just do not forget to push this version to NPM as well