n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

Clearing all spots causes an Access Violation #106

Closed ny4i closed 8 years ago

ny4i commented 8 years ago

When right clicking on the spot window and clicking to remove all spots, the program faults with an access violation.

The place this stops is in uSport.pas at line 382

function TDXSpotsList.Get(Index: integer): TSpotRecord;
begin
  //  if (Index < 0) or (Index >= FCount) then Exit; //ERROR(@SListIndexError, Index);
  Result := FList^[Index]; // This line faults. It appears that FList^ is not a valid pointer. Try...except?
end;
n4af commented 8 years ago

Thanks for your detective work Tom.

I enabled the commented test, and that circumvents the problem. I will shortly upload beta-1

Am sure Gavin is in Z land, but perhaps he can review tomorrow.

73, Howie

http://n4af.net

On Tue, Feb 16, 2016 at 8:15 PM, Tom Schaefer notifications@github.com wrote:

When right clicking on the spot window and clicking to remove all spots, the program faults with an access violation.

The place this stops is in uSport.pas at line 382

function TDXSpotsList.Get(Index: integer): TSpotRecord;begin // if (Index < 0) or (Index >= FCount) then Exit; //ERROR(@SListIndexError, Index); \ Result := FList^[Index];**end;

— Reply to this email directly or view it on GitHub https://github.com/n4af/TR4W/issues/106.

gm0gav commented 8 years ago

This is a strange one, I have been trying to replicate on 4.46.beta and it was all fine until I deleted an individual spot, then did a remove all spots.

Will have a look tonight

73 Gav

n4af commented 8 years ago

Gavin -

Can this be closed ? Tks, Howie

ny4i commented 8 years ago

I saw a related issue. When I cleared the band map, the display changes to strange characters momentarily. It's as if the band map is cleared but a final display shows strange characters.

Principal Solutions Architect Better Software Solutions, Inc. 727-437-2771

On Feb 24, 2016, at 7:25 AM, Howie Hoyt notifications@github.com wrote:

Gavin -

Can this be closed ? Tks, Howie

— Reply to this email directly or view it on GitHub https://github.com/n4af/TR4W/issues/106#issuecomment-188227147.

gm0gav commented 8 years ago

On 24/02/2016 12:25, Howie Hoyt wrote:

Gavin -

Can this be closed ? Tks, Howie

— Reply to this email directly or view it on GitHub https://github.com/n4af/TR4W/issues/106#issuecomment-188227147.

I am sure this can be closed

ny4i commented 8 years ago

I will turn this into another one then. The flash of garbage characters is a bug. I was thinking since it was related to clearing all that we could use this issue but it’s easy to open another one.

Thanks,

Tom

Principal Solutions Architect, ITIL®v3 Better Software Solutions, Inc. 727-437-BSS1 (727-437-2771) @BSSI_Consulting

On Feb 25, 2016, at 3:48 PM, gm0gav notifications@github.com wrote:

On 24/02/2016 12:25, Howie Hoyt wrote:

Gavin -

Can this be closed ? Tks, Howie

— Reply to this email directly or view it on GitHub https://github.com/n4af/TR4W/issues/106#issuecomment-188227147.

I am sure this can be closed — Reply to this email directly or view it on GitHub https://github.com/n4af/TR4W/issues/106#issuecomment-188978586.