n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

Move version info to its own file #545

Closed ny4i closed 2 years ago

ny4i commented 2 years ago

Many times when I change config items like a new rig, I make changes to VC.pas. Many times the only change Howie makes each release to VC.pas is the version string. Those changes collide when I try to refresh my branch from Master. If the version info was in its own file, this would avoid collisions.

I suggest the following constants be moved to their own file called version.pas.

const
 TR4W_CURRENTVERSION_NUMBER            = '4.105.7' ;  // N4af     New Release

  TR4W_CURRENTVERSION                   = 'TR4W v.' + TR4W_CURRENTVERSION_NUMBER; //  {$IF MMTTYMODE} + '_mmtty'{$IFEND};//{$IF LANG <> 'ENG'} + ' [' + LANG + ']'{$IFEND}{$IF MMTTYMODE} + '_mmtty'{$IFEND};
  TR4W_CURRENTVERSIONDATE               = 'November, 2021' ;

  TR4WSERVER_CURRENTVERSION             = '1.41';
n4af commented 2 years ago

implemented 4.105.10

n4af commented 2 years ago

If I move Version out- unit version;

interface

implementation

const TR4W_CURRENTVERSION_NUMBER = '4.105.10' ; // N4af New Release

TR4W_CURRENTVERSION = 'TR4W v.' + TR4W_CURRENTVERSION_NUMBER; // {$IF MMTTYMODE} + '_mmtty'{$IFEND};//{$IF LANG <> 'ENG'} + ' [' + LANG + ']'{$IFEND}{$IF MMTTYMODE} + '_mmtty'{$IFEND}; TR4W_CURRENTVERSIONDATE = 'November, 2021' ;

TR4WSERVER_CURRENTVERSION = '1.41';

end.

and then set up Main.pas with Version in the USES

Main fails with a messages like [Error] MainUnit.pas(442): Undeclared identifier: 'TR4W_CURRENTVERSION'

On Sun, Nov 14, 2021 at 6:07 PM Tom Schaefer @.***> wrote:

Assigned #545 https://github.com/n4af/TR4W/issues/545 to @n4af https://github.com/n4af.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/545#event-5614852646, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUCWT74GCYAZQSLDJXTUMA6JNANCNFSM5IAMF33A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

n4af commented 2 years ago

ok. I (think) it is good on github.