n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

ADIF export cqww wrong #554

Closed n4af closed 2 years ago

n4af commented 2 years ago
CQWWCW should be CQ-WW-CW in the generated ADIF file
ny4i commented 2 years ago

In PostUnit, there is logic to say that if the ADIFNAme(might have the wrong name) is NOT blank (that is in the contests array), use that. Otherwise, use the contest name. But as I mentioned, it was not clear what is removing the _ from the name.

Tom

On Nov 30, 2021, at 9:54 AM, Howie Hoyt @.***> wrote:

CQWWCW should be CQ-WW-CW in the generated ADIF file — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or unsubscribe .
n4af commented 2 years ago

fixed 4.105.17

ny4i commented 2 years ago

What was the issue?

Tom

On Nov 30, 2021, at 10:02 AM, Howie Hoyt @.***> wrote:

Closed #554 https://github.com/n4af/TR4W/issues/554.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#event-5692643927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6TWSU6A523BXF3BFTXP7LUOTRSHANCNFSM5JCASWKQ.

n4af commented 2 years ago

VC contests array iine for cq-ww-cw ADIF='' had ADIF='CQWWCW'

On Tue, Nov 30, 2021 at 10:04 AM Tom Schaefer @.***> wrote:

What was the issue?

Tom

On Nov 30, 2021, at 10:02 AM, Howie Hoyt @.***> wrote:

Closed #554 https://github.com/n4af/TR4W/issues/554.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/n4af/TR4W/issues/554#event-5692643927>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC6TWSU6A523BXF3BFTXP7LUOTRSHANCNFSM5JCASWKQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982720936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUF62AUGHJHKIXYSIR3UOTRWXANCNFSM5JCASWKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

n4af commented 2 years ago

https://github.com/n4af/TR4W/commit/e3ffd444ad52830a251c03aef5bbcdc63309c5b9

On Tue, Nov 30, 2021 at 9:58 AM Tom Schaefer @.***> wrote:

In PostUnit, there is logic to say that if the ADIFNAme(might have the wrong name) is NOT blank (that is in the contests array), use that. Otherwise, use the contest name. But as I mentioned, it was not clear what is removing the _ from the name.

Tom

On Nov 30, 2021, at 9:54 AM, Howie Hoyt @.***> wrote:

CQWWCW should be CQ-WW-CW in the generated ADIF file — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/n4af/TR4W/issues/554>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC6TWSSWXTY67JQM2S3W5RDUOTQSVANCNFSM5JCASWKQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982715422, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUDVBGANTSXVXWKZ2GTUOTRBZANCNFSM5JCASWKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ny4i commented 2 years ago

I see it now. Did you fill in the ADIFNAME with CQWWCW? I did not see that originally in my branch but I see it is there now.

Tom

On Nov 30, 2021, at 10:09 AM, Howie Hoyt @.***> wrote:

https://github.com/n4af/TR4W/commit/e3ffd444ad52830a251c03aef5bbcdc63309c5b9

On Tue, Nov 30, 2021 at 9:58 AM Tom Schaefer @.***> wrote:

In PostUnit, there is logic to say that if the ADIFNAme(might have the wrong name) is NOT blank (that is in the contests array), use that. Otherwise, use the contest name. But as I mentioned, it was not clear what is removing the _ from the name.

Tom

On Nov 30, 2021, at 9:54 AM, Howie Hoyt @.***> wrote:

CQWWCW should be CQ-WW-CW in the generated ADIF file — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/n4af/TR4W/issues/554>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC6TWSSWXTY67JQM2S3W5RDUOTQSVANCNFSM5JCASWKQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982715422, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUDVBGANTSXVXWKZ2GTUOTRBZANCNFSM5JCASWKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982726558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6TWSR2FTUIRRIEYONCACDUOTSMNANCNFSM5JCASWKQ.

n4af commented 2 years ago

probably...

On Tue, Nov 30, 2021 at 10:49 AM Tom Schaefer @.***> wrote:

I see it now. Did you fill in the ADIFNAME with CQWWCW? I did not see that originally in my branch but I see it is there now.

Tom

On Nov 30, 2021, at 10:09 AM, Howie Hoyt @.***> wrote:

https://github.com/n4af/TR4W/commit/e3ffd444ad52830a251c03aef5bbcdc63309c5b9

On Tue, Nov 30, 2021 at 9:58 AM Tom Schaefer @.***> wrote:

In PostUnit, there is logic to say that if the ADIFNAme(might have the wrong name) is NOT blank (that is in the contests array), use that. Otherwise, use the contest name. But as I mentioned, it was not clear what is removing the _ from the name.

Tom

On Nov 30, 2021, at 9:54 AM, Howie Hoyt @.***> wrote:

CQWWCW should be CQ-WW-CW in the generated ADIF file — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/n4af/TR4W/issues/554>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AC6TWSSWXTY67JQM2S3W5RDUOTQSVANCNFSM5JCASWKQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982715422, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABVLCUDVBGANTSXVXWKZ2GTUOTRBZANCNFSM5JCASWKQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/n4af/TR4W/issues/554#issuecomment-982726558>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC6TWSR2FTUIRRIEYONCACDUOTSMNANCNFSM5JCASWKQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/554#issuecomment-982765114, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUHQMXQM6ZWRHDXPFZDUOTXBBANCNFSM5JCASWKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.