search

n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

Generated ADIF can include <GRIDSQUARE when no grid is in exchange #627

Closed n4af closed 1 year ago

n4af commented 1 year ago

If the domestic consists of two letters and two numbers, for example, CM42, then the program defines this as GRID and CM42 is entered in ADIF.

UA4AAC 40m 20221204 093855 093855 599 599 GENERAL QSO CW CM42 599 CM196 CM42 CM42 00001 UR7QM
n4af commented 1 year ago

The problem resides within function LooksLikeAGrid in Tree.pas LooksLikeAGrid now checks Active Exchange for a grid exchange, else it returns FALSE, and hence POST will not generate GRIDSQUARE. Fix 4.118.1

ny4i commented 1 year ago

Lookslikeagrid is used for WSJT-X in real-time. I think the real issue is if the 4CM42 is returning true because that doesn’t look like a grid. TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:39 AM, Howie Hoyt @.***> wrote: The problem resides within function LooksLikeAGrid in Tree.pas LooksLikeAGrid now checks Active Exchange for a grid exchange, else it returns FALSE, and hence POST will not generate GRIDSQUARE. Fix 4.118.1

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

ny4i commented 1 year ago

Lookslikeagrid is used for WSJT-X in real-time. I think the real issue is if the 4CM… is returning true because that doesn’t look like a grid. TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:39 AM, Howie Hoyt @.***> wrote: The problem resides within function LooksLikeAGrid in Tree.pas LooksLikeAGrid now checks Active Exchange for a grid exchange, else it returns FALSE, and hence POST will not generate GRIDSQUARE. Fix 4.118.1

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

n4af commented 1 year ago

Hi Tom -

I do not know what 4cm42 is but if you can forward me a fix, we can test it out...

On Mon, Dec 5, 2022 at 5:51 AM Tom Schaefer @.***> wrote:

Lookslikeagrid is used for WSJT-X in real-time. I think the real issue is if the 4CM… is returning true because that doesn’t look like a grid. TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:39 AM, Howie Hoyt @.***> wrote: The problem resides within function LooksLikeAGrid in Tree.pas LooksLikeAGrid now checks Active Exchange for a grid exchange, else it returns FALSE, and hence POST will not generate GRIDSQUARE. Fix 4.118.1

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/627#issuecomment-1337128096, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUDXDL52N5I22MC4WQDWLXCLPANCNFSM6AAAAAASUBM3KA . You are receiving this because you were assigned.Message ID: @.***>

ny4i commented 1 year ago

I guess I’m confused. If the user enters CM42 in the exchange, that is a grid. The 4CM42 was because the ADIF you sent in the bug was missing the <> characters. Was this not a grid?TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:36 AM, Howie Hoyt @.***> wrote: If the domestic consists of two letters and two numbers, for example, CM42, then the program defines this as GRID and GRIDSQUARE:4CM42 is entered in ADIF. CALL:6UA4AAC BAND:340m 20221204 093855 093855

599 599 GENERAL QSO MODE:2CW CM42 599 CM196 STATE:4CM42 GRIDSQUARE:4CM42 STX:500001 OPERATOR:5UR7QM —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
ny4i commented 1 year ago

Was this the real ADIF or a formatting error in GitHub?CALL:6UA4AAC BAND:340m 20221204 093855 093855599 599 GENERAL QSO MODE:2CW CM42599 CM196 STATE:4CM42 GRIDSQUARE:4CM42 STX:500001 OPERATOR:5UR7QMPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:36 AM, Howie Hoyt @.***> wrote: If the domestic consists of two letters and two numbers, for example, CM42, then the program defines this as GRID and GRIDSQUARE:4CM42 is entered in ADIF. CALL:6UA4AAC BAND:340m 20221204 093855 093855

599 599 GENERAL QSO MODE:2CW CM42 599 CM196 STATE:4CM42 GRIDSQUARE:4CM42 STX:500001 OPERATOR:5UR7QM —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
n4af commented 1 year ago

What is entered in the exchange depends on ACTIVE EXCHANGE. If GRID is not part of the active exchange then we do not want to generate <GRIDSQUARE- instead it becomes <QTH

On Mon, Dec 5, 2022 at 9:24 AM Tom Schaefer @.***> wrote:

I guess I’m confused. If the user enters CM42 in the exchange, that is a grid. The 4CM42 was because the ADIF you sent in the bug was missing the <> characters. Was this not a grid?TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:36 AM, Howie Hoyt @.***> wrote: If the domestic consists of two letters and two numbers, for example, CM42, then the program defines this as GRID and GRIDSQUARE:4CM42 is entered in ADIF. CALL:6UA4AAC BAND:340m 20221204 093855

093855 599 599 GENERAL QSO MODE:2CW CM42 599 CM196 STATE:4CM42 GRIDSQUARE:4CM42 STX:500001 OPERATOR:5UR7QM —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were assigned.Message ID: ***@***.***>
ny4i commented 1 year ago

Right but if I’m in General QSO mode and I enter CM42 as a grid, that is indeed a grid and I would think GRIDSQUARE should be in the ADIF. I don’t know why a 40m CW QSO would have a grid but if it does, the only place to export it is in the gridsquare field. But maybe that was a contrived example. TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 9:29 AM, Howie Hoyt @.***> wrote: What is entered in the exchange depends on ACTIVE EXCHANGE. If GRID is not part of the active exchange then we do not want to generate <GRIDSQUARE- instead it becomes <QTH

On Mon, Dec 5, 2022 at 9:24 AM Tom Schaefer @.***> wrote:

I guess I’m confused. If the user enters CM42 in the exchange, that is a grid. The 4CM42 was because the ADIF you sent in the bug was missing the <> characters. Was this not a grid?TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 4:36 AM, Howie Hoyt @.***> wrote: If the domestic consists of two letters and two numbers, for example, CM42, then the program defines this as GRID and GRIDSQUARE:4CM42 is entered in ADIF. CALL:6UA4AAC BAND:340m 20221204 093855

093855 599 599 GENERAL QSO MODE:2CW CM42 599 CM196 STATE:4CM42 GRIDSQUARE:4CM42 STX:500001 OPERATOR:5UR7QM —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were assigned.Message ID: ***@***.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

n4af commented 1 year ago

Some what nuts, but in ARTIKA-SPRING, as example, CM42 is a QTH. Perhaps more germane the EXCHANGE RECEIVED parm in the Custom Config is

EXCHANGE RECEIVED = RST QSO NUMBER AND DOMESTIC QTH

That is why I added code to parse Active Exchange...

ny4i commented 1 year ago

I can’t find the rules for that one to check.

Tom

Principal Solutions Architect Better Software Solutions, Inc. 727-437-2771

On Dec 5, 2022, at 9:36 AM, Howie Hoyt @.***> wrote:

ARTIKA-SPRING

n4af commented 1 year ago

yup. some sorta russian contest but the custom cfg is legit: MY CALL = UR7QM MY STATE = CM196 CONTEST = GENERAL QSO contest title = artika-spring EXCHANGE RECEIVED = RST QSO NUMBER AND DOMESTIC QTH

On Mon, Dec 5, 2022 at 9:39 AM Tom Schaefer @.***> wrote:

I can’t find the rules for that one to check.

Tom

Principal Solutions Architect Better Software Solutions, Inc. 727-437-2771

On Dec 5, 2022, at 9:36 AM, Howie Hoyt @.***> wrote:

ARTIKA-SPRING

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/627#issuecomment-1337491082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUEZHTAB37GZGJAHDG3WLX5CJANCNFSM6AAAAAASUBM3KA . You are receiving this because you were assigned.Message ID: @.***>

ny4i commented 1 year ago

Ok. Now I see the problem. Principal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 9:42 AM, Howie Hoyt @.***> wrote: yup. some sorta russian contest but the custom cfg is legit: MY CALL = UR7QM MY STATE = CM196 CONTEST = GENERAL QSO contest title = artika-spring EXCHANGE RECEIVED = RST QSO NUMBER AND DOMESTIC QTH

On Mon, Dec 5, 2022 at 9:39 AM Tom Schaefer @.***> wrote:

I can’t find the rules for that one to check.

Tom

Principal Solutions Architect Better Software Solutions, Inc. 727-437-2771

On Dec 5, 2022, at 9:36 AM, Howie Hoyt @.***> wrote:

ARTIKA-SPRING

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/627#issuecomment-1337491082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUEZHTAB37GZGJAHDG3WLX5CJANCNFSM6AAAAAASUBM3KA . You are receiving this because you were assigned.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

ny4i commented 1 year ago

Meaning if a contest is crazy enough to have something that looks like a grid, it’s hard to do anything but what you did. ThanksPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Dec 5, 2022, at 9:42 AM, Howie Hoyt @.***> wrote: yup. some sorta russian contest but the custom cfg is legit: MY CALL = UR7QM MY STATE = CM196 CONTEST = GENERAL QSO contest title = artika-spring EXCHANGE RECEIVED = RST QSO NUMBER AND DOMESTIC QTH

On Mon, Dec 5, 2022 at 9:39 AM Tom Schaefer @.***> wrote:

I can’t find the rules for that one to check.

Tom

Principal Solutions Architect Better Software Solutions, Inc. 727-437-2771

On Dec 5, 2022, at 9:36 AM, Howie Hoyt @.***> wrote:

ARTIKA-SPRING

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/627#issuecomment-1337491082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUEZHTAB37GZGJAHDG3WLX5CJANCNFSM6AAAAAASUBM3KA . You are receiving this because you were assigned.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>