n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

HamLib Implementation #684

Closed ny4i closed 10 months ago

ny4i commented 10 months ago

This is a significant upgrade to TR4W to add hamlib support. Hamlib is the ham radio control library that WSJT-X and several other programs use. This allows us to automatically support radios that hamlib already supports such as the Expert Interface TCI requested in issue #446 . This also adds support for the Yaesu 757GXII and the Ten Tec Omni. The Flex should also work over the network.

There is also support to add a radio that is not specifically in the list but the hamlib ID is known as hamlib adds it. This allows hamlib to stay ahead of TR4W. At the moment, setting the hamlibID would have to be set in the INI file if TR4W's radio setup windows does not mention the radio.

Note this only works at the time for a single radio. I have yet to add the code to run two instances of rigctld but that will be easy once I get some feedback.

MY main concern is to make sure I have not broken anything. In all the LogRadio RadioObject functions, I just added code at the top to call HamLib if set. If not hamlib, then the regular rig control is set to run. This is similar to how I did the K4 network code.

CW by CAT should work for any radios that support it as does PlayMessage. Split should work as well. I tested tuning from the bandmap among other things so this should be ready to go but I do expect bug reports as people test it. Mainly the issue may be if a feature is used that the radio does not support through HamLib (direct VFOB control is one example that some rigs do not support--looking at you Yaesu).

Once built, I can send an announcement to the mailing list explaining how to use some of the features along with the link to the code.

This closes #676.

n4af commented 10 months ago

Great job Tom !

https://tr4w.net/4.125/tr4w_setup_4_125.1.exe

On Tue, Aug 22, 2023 at 10:48 AM Tom Schaefer @.***> wrote:

This is a significant upgrade to TR4W to add hamlib support. Hamlib is the ham radio control library that WSJT-X and several other programs use. This allows us to automatically support radios that hamlib already supports such as the Expert Interface TCI requested in issue #446 https://github.com/n4af/TR4W/issues/446 . This also adds support for the Yaesu 757GXII and the Ten Tec Omni. The Flex should also work over the network.

There is also support to add a radio that is not specifically in the list but the hamlib ID is known as hamlib adds it. This allows hamlib to stay ahead of TR4W. At the moment, setting the hamlibID would have to be set in the INI file if TR4W's radio setup windows does not mention the radio.

Note this only works at the time for a single radio. I have yet to add the code to run two instances of rigctld but that will be easy once I get some feedback.

MY main concern is to make sure I have not broken anything. In all the LogRadio RadioObject functions, I just added code at the top to call HamLib if set. If not hamlib, then the regular rig control is set to run. This is similar to how I did the K4 network code.

CW by CAT should work for any radios that support it as does PlayMessage. Split should work as well. I tested tuning from the bandmap among other things so this should be ready to go but I do expect bug reports as people test it. Mainly the issue may be if a feature is used that the radio does not support through HamLib (direct VFOB control is one example that some rigs do not support--looking at you Yaesu).

Once built, I can send an announcement to the mailing list explaining how to use some of the features along with the link to the code.

You can view, comment on, or merge this pull request online at:

https://github.com/n4af/TR4W/pull/684 Commit Summary

File Changes

(16 files https://github.com/n4af/TR4W/pull/684/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/pull/684, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUD5IPGLNF4P66LIE43XWTBCTANCNFSM6AAAAAA32BQZJQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ny4i commented 10 months ago

Howie - I assume you are waiting for testing before you merge this into MASTER? Good plan if so...

n4af commented 10 months ago

Hi Tom -

No, the master should include all the changes ??

On Tue, Aug 22, 2023 at 5:21 PM Tom Schaefer @.***> wrote:

Howie - I assume you are waiting for testing before you merge this into MASTER? Good plan if so...

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/pull/684#issuecomment-1688949170, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUHBP2FOYQZ6G2FVTOLXWUPGVANCNFSM6AAAAAA32BQZJQ . You are receiving this because you commented.Message ID: @.***>

ny4i commented 10 months ago

Ok. Well the pull request was still active so it did not appear merged. TomPrincipal Solutions ArchitectBetter Software Solutions, Inc. 727-437-2771On Aug 23, 2023, at 6:30 AM, Howie Hoyt @.***> wrote: Hi Tom -

No, the master should include all the changes ??

On Tue, Aug 22, 2023 at 5:21 PM Tom Schaefer @.***>

wrote:

Howie - I assume you are waiting for testing before you merge this into

MASTER? Good plan if so...

Reply to this email directly, view it on GitHub

https://github.com/n4af/TR4W/pull/684#issuecomment-1688949170, or

unsubscribe

https://github.com/notifications/unsubscribe-auth/ABVLCUHBP2FOYQZ6G2FVTOLXWUPGVANCNFSM6AAAAAA32BQZJQ

.

You are receiving this because you commented.Message ID:

@.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>