search

n4af / TR4W

TRLOG 4 Windows free amateur radio logging application
GNU General Public License v3.0
19 stars 6 forks source link

Tune Spot using RadioTwo #760

Open ny4i opened 2 months ago

ny4i commented 2 months ago

This is strange. Between the line,

TuneRadioToSpot(TempSpot, RadioOne); in TelnetWndDlgProc in uTelnet

and procedure SetRadioFreq(Radio: RadioType; Freq: longint; Mode: ModeType; VFO: char); in LogRadio, the radio object was passed as RadioOne but appears in the debugger as RadioTwo.

Were there any changes recently that could have affected the active radio pointer?

n4af commented 2 months ago

sigh, yeah i will take a look.

73, Howie

On Sun, Apr 28, 2024 at 3:45 PM Tom Schaefer @.***> wrote:

This is strange. Between the line,

TuneRadioToSpot(TempSpot, RadioOne); in TelnetWndDlgProc in uTelnet

and procedure SetRadioFreq(Radio: RadioType; Freq: longint; Mode: ModeType; VFO: char); in LogRadio, the radio object was passed as RadioOne but appears in the debugger as RadioTwo.

Were there any changes recently that could have affected the active radio pointer?

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/760, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUAPMLLLBLVQWLFCNBLY7VGWXAVCNFSM6AAAAABG5HIAD6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DONZYGE4TINA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ny4i commented 2 months ago

This works on 4.132.3, 4.133.1 but does NOT work as of 4.133.2

Hence one could conclude one of the changes in 4.133.2 broke it. That would be this change according to the release notes:

4.133.02 #757 SO2R fails to switch band & freq display (N4AF)

If you are doing something with the activeRadioObj you may need to lock that code if the Radio passes to SetRadioFreq is a pointer. Or dereference the pointer and p[ass the actual object (but I have not examined it enough to know if that is the issue).

n4af commented 2 months ago

Hi Tom -

Could you try 4.134.1 https://tr4w.net/4.134/tr4w_setup_4_134.1.exeto verify all is ok ??

Tks, Howie

On Sun, Apr 28, 2024 at 3:56 PM Tom Schaefer @.***> wrote:

This works on 4.132.3, 4.133.1 but does NOT work as of 4.133.2

Hence one could conclude one of the changes in 4.133.2 broke it. That would be this change according to the release notes:

4.133.02 #757 https://github.com/n4af/TR4W/issues/757 SO2R fails to switch band & freq display (N4AF)

If you are doing something with the activeRadioObj you may need to lock that code if the Radio passes to SetRadioFreq is a pointer. Or dereference the pointer and p[ass the actual object (but I have not examined it enough to know if that is the issue).

— Reply to this email directly, view it on GitHub https://github.com/n4af/TR4W/issues/760#issuecomment-2081633634, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVLCUEETLE7WLV5LBWNVZ3Y7VH6FAVCNFSM6AAAAABG5HIAD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGYZTGNRTGQ . You are receiving this because you commented.Message ID: @.***>

ny4i commented 2 months ago

Yes - that works Howie. Thanks