search

n4bb12 / verdaccio-github-oauth-ui

📦🔐 GitHub OAuth plugin for Verdaccio
https://verdaccio.org
MIT License
73 stars 45 forks source link

Interest in other OAuth Implementations? #101

Closed DarkMio closed 3 years ago

DarkMio commented 3 years ago

Hi,

we're maintaining internally a fork of this plugin to connect to Azure Active Directories via OpenID, since the process is similar (except group authentication) and I wanted to ask if there's generally interest to extend this plugin to support multiple platforms and/or more generalized OpenID logins.

If not, we're going to keep our fork separate.

n4bb12 commented 3 years ago

I see how that would be useful but I don't have plans to extend this plugin beyond GitHub. I might write a more generic plugin in the non-near future.

DarkMio commented 3 years ago

I have code for that already in place. It's not even far off from this master, it mostly needs slight changes to src/server/Config.ts to allow for more configs (as well as the general structure of the config) and some decoupling in AuthCore. From there it's pretty smooth sailing for other providers, like Azure where the bearer token needs to access MS Graph APIs to figure out organization/group assignments.

If there's some interest, I might open up two separate PRs, one that makes configuration / API implementations more generic and after that a PR with the Azure OpenID implementation.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

manuschillerdev commented 2 years ago

I have code for that already in place. It's not even far off from this master, it mostly needs slight changes to src/server/Config.ts to allow for more configs (as well as the general structure of the config) and some decoupling in AuthCore. From there it's pretty smooth sailing for other providers, like Azure where the bearer token needs to access MS Graph APIs to figure out organization/group assignments.

If there's some interest, I might open up two separate PRs, one that makes configuration / API implementations more generic and after that a PR with the Azure OpenID implementation.

any interest in open-sourcing your approach? :) Would be really cool to have a more generic oidc plugin for verdaccio

DarkMio commented 2 years ago

Here you go: https://github.com/DarkMio/verdaccio-azure-oauth-ui

That's azure specific, but you can kinda guesstimate what needs to be done to support generic oidc things. Azure is a bit special in regards of how to retrieve users from Microsofts graph API

OnekO commented 2 years ago

I have a fork here which allows to login using Authelia: https://github.com/OnekO/verdaccio-github-oauth-ui

At least with Authelia it's working, I'll fix a few tests and leave there, maybe @n4bb12 wants to merge it, or maybe it will be useful to anybody who ends here looking for that.

Thx for the project, it's a good job