Closed egetin closed 5 years ago
Hi @egetin,
sorry for the trouble you've had debugging your configuration.
I've added validation for all required configuration props. You'll now get a message like this:
- [github-oauth-ui] ERR: missing configuration "auth.github-oauth-ui.org",
- please check your verdaccio config
This is implemented in 1.7.0 https://www.npmjs.com/package/verdaccio-github-oauth-ui
Thanks for reporting!
Bug Report
Versions
Expected behavior
If
client-id
andclient-secret
are missing, the plugin should throw a descriptive error and stop Verdaccio from starting up.Observed behaviour
If
client-id
andclient-secret
are missing, no errors are brought up on the Verdaccio log and the login button in UI will just open the default login modal.Steps to reproduce
middlewares
block from Verdaccio'sconfig.yaml
Additional context
I had written incorrectly
middleware:
instead ofmiddlewares:
in theconfig.yaml
and was wondering for a long time why the plugin wouldn't work (login button opened the default login modal). Some sort of error from missing required configuration would make debugging a lot easier.