n4bb12 / verdaccio-github-oauth-ui

📦🔐 GitHub OAuth plugin for Verdaccio
https://verdaccio.org
MIT License
74 stars 45 forks source link

WIP Inject html with id value instead of className #23

Closed JeremyTX closed 5 years ago

JeremyTX commented 5 years ago

@n4bb12 please review when you get a chance. thank you!

mikeseese commented 5 years ago

@n4bb12 I'm curious what is WIP about this PR? What needs to change for it to be merged? This plugin doesn't work without this PR (I'm guessing it'll work just by reading the code; I haven't tested it) for Verdaccio v4.2.1 (not sure what version it's not broken for without more research)

Edit: I'll backtrack my version of verdaccio to get up and running, but it seems this, and other PR's by @JeremyTX, add support for v4

n4bb12 commented 5 years ago

@JeremyTX @seesemichaelj

I'm not sure what to review as there is no description of intention and changes made.

You can fire up verdaccio with the plugin by running ./run update or ./run watch followed by a ./run start in a bash.

The dev tasks use the verdaccio.template.yaml which you can customize locally for testing. Alternatively you can configure your github org via environment variables.

Please make sure the login/logout and local publishing works when requesting a review.

n4bb12 commented 5 years ago

@seesemichaelj the other two PRs by @JeremyTX are maked as WIP by JeremyTX himself, so I haven't had a look at those yet.

n4bb12 commented 5 years ago

@JeremyTX are you still working on this?

n4bb12 commented 5 years ago

Closing this as it refers to v4 and has been unfinished for a while. Please open a new PR if you intend to complete this.