Closed JeremyTX closed 5 years ago
@n4bb12 I'm curious what is WIP about this PR? What needs to change for it to be merged? This plugin doesn't work without this PR (I'm guessing it'll work just by reading the code; I haven't tested it) for Verdaccio v4.2.1 (not sure what version it's not broken for without more research)
Edit: I'll backtrack my version of verdaccio to get up and running, but it seems this, and other PR's by @JeremyTX, add support for v4
@JeremyTX @seesemichaelj
I'm not sure what to review as there is no description of intention and changes made.
Please update the dev dependency to v4, too, if this is intended to be a migration PR.
Unfortunately this throws an error during login.
TypeError: this.auth.issueUIjwt is not a function
You can fire up verdaccio with the plugin by running ./run update
or ./run watch
followed by a ./run start
in a bash.
The dev tasks use the verdaccio.template.yaml
which you can customize locally for testing. Alternatively you can configure your github org via environment variables.
Please make sure the login/logout and local publishing works when requesting a review.
The PR breaks functionality for verdaccio 3 users. If this is intended to be a migration, please label the PR as such and list the breaking changes.
I've noticed that incorrect/superseded commands are shown in v4, which were removed in v3. For instance npm adduser
doesn't make sense in this context.
@seesemichaelj the other two PRs by @JeremyTX are maked as WIP by JeremyTX himself, so I haven't had a look at those yet.
@JeremyTX are you still working on this?
Closing this as it refers to v4 and has been unfinished for a while. Please open a new PR if you intend to complete this.
@n4bb12 please review when you get a chance. thank you!