search

n4bb12 / verdaccio-github-oauth-ui

📦🔐 GitHub OAuth plugin for Verdaccio
https://verdaccio.org
MIT License
74 stars 45 forks source link

Add support for file based configuration to support Docker secrets/config #55

Closed myrddraall closed 4 years ago

myrddraall commented 4 years ago

This adds 4 new options to the plugin's configuration that take a path to a file and override their respective options with the content of the file.

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will increase coverage by 2.66%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   29.12%   31.79%   +2.66%     
==========================================
  Files          25       25              
  Lines         333      346      +13     
  Branches       43       45       +2     
==========================================
+ Hits           97      110      +13     
  Misses        236      236
Impacted Files Coverage Δ
src/server/plugin/Config.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5289f2...5fa19ce. Read the comment docs.

n4bb12 commented 4 years ago

Thanks for the PR.

I'm not convinced of the feature. I don't want to support having each configuration value in a separate file. You can already use environment variables which I think is a much more common approach to configuration. If you prefer configuring things this way, you also have the option of maintaining a fork.

myrddraall commented 4 years ago

I think is a much more common approach to configuration

Not in swarm environments. Many docker images support it https://docs.docker.com/engine/swarm/secrets/