Closed ganapativs closed 4 years ago
Do you have the same problem with 2.3.2
?
Yes. Both 2.3.1
and 2.3.2
has the same issue. For now, I'm sticking with 2.3.0
.
Also, the command is still waiting even after the error occurs.
Found the issue. It took me a while to reproduce because it requires a different server and CLI version.
In 2.3.0 the CLI callback path is /
.
In 2.3.1 the CLI callback path changed to /success
, /denied
and /error
in order to provide better error feedback.
But while the CLI handles redirection and writing the token to .npmrc
, the corresponding callback request handler is registered by the server-side Verdaccio plugin. This unclean mix of concerns is now causing your issue.
Yes, there is a version mismatch. on the client-side, I was trying with 2.3.1
, while, the server has 2.2.4
.
On a side note: should we ask for both client and server versions in issue template?
good idea, we could add the node version, too
Bug Report
Plugin breaks with
Cannot GET /
in the UI when running withnpx verdaccio-github-oauth-ui@2.3.1 --registry https://registry.website.com/
. This started happening from2.3.1
. The plugin works fine till2.3.0
.Tested on Mac and Ubuntu, facing the same issue.
Versions
Expected behavior
Should successfully authenticate and update the
.npmrc
file.Observed behaviour
Plugin breaks with
Cannot GET /
in the UISteps to reproduce
npx verdaccio-github-oauth-ui@2.3.1 --registry https://registry.website.com/
Cannot GET /
in the UI