Cannot GET / in the UI

[ganapativs]

Bug Report

Plugin breaks with Cannot GET / in the UI when running with npx verdaccio-github-oauth-ui@2.3.1 --registry https://registry.website.com/. This started happening from 2.3.1. The plugin works fine till 2.3.0.

Tested on Mac and Ubuntu, facing the same issue.

Versions

	Version
verdaccio	4.7.1
verdaccio-github-oauth-ui	2.3.1

Expected behavior

Should successfully authenticate and update the .npmrc file.

Observed behaviour

Plugin breaks with Cannot GET / in the UI

Steps to reproduce

1. Run npx verdaccio-github-oauth-ui@2.3.1 --registry https://registry.website.com/
2. Plugin breaks with Cannot GET / in the UI

[n4bb12]

Do you have the same problem with 2.3.2?

[ganapativs]

Yes. Both 2.3.1 and 2.3.2 has the same issue. For now, I'm sticking with 2.3.0.

[ganapativs]

Also, the command is still waiting even after the error occurs.

[n4bb12]

Found the issue. It took me a while to reproduce because it requires a different server and CLI version.

In 2.3.0 the CLI callback path is /. In 2.3.1 the CLI callback path changed to /success, /denied and /error in order to provide better error feedback.

But while the CLI handles redirection and writing the token to .npmrc, the corresponding callback request handler is registered by the server-side Verdaccio plugin. This unclean mix of concerns is now causing your issue.

[ganapativs]

Yes, there is a version mismatch. on the client-side, I was trying with 2.3.1, while, the server has 2.2.4.

On a side note: should we ask for both client and server versions in issue template?

[n4bb12]

good idea, we could add the node version, too

[n4bb12]

CLI 2.3.3 works with server versions <=2.3.0 and >=2.3.3.

Thanks you for reporting it! 🍻