search

n4kz / react-native-indicators

Activity indicator collection for React Native
Other
899 stars 116 forks source link

update componentWillReceiveProps to componentDidUpdate #28

Closed kingbin closed 4 years ago

kingbin commented 4 years ago

Fix for issue #26 componentWillReceiveProps is an sync function which is being deprecated in favor of using componentDidUpdate which is async. Also fixes a rendering issue I found on Android.

kingbin commented 4 years ago

why not take the merge request?

n4kz commented 4 years ago

Thanks for asking. This change was not just about rename. Method body also required refactoring because componentDidUpdate is called after update and change of component props. Please, take a look at 2b1dfe4f for more details.