search

n4kz / react-native-material-dropdown

Material dropdown with consistent behaviour on iOS and Android
Other
732 stars 597 forks source link

Fixed componentWillReceiveProps warning #204

Open AureliaRoumesy opened 4 years ago

AureliaRoumesy commented 4 years ago

Update react-native-material-textfield version react-native-material-buttons version

Fixed

Deprecation warnings for React component lifecycle methods

Issue #192

muhammadsr commented 4 years ago

can we merge this?

YahiaBadr commented 4 years ago

Please merge the warnings are so annoying. Hope this project didn't reach a dead end.

yaron1m commented 4 years ago

Please merge this 🙏

xvonabur commented 4 years ago

This PR changed default behaviour. Suppose I have separate values and labels for dropdown options like this: 

{
  label: 'Zero cases',
  value: '0'
}

After I press dropdown, I see Zero cases text, but field changes to 0 after selecting this option. I would like to see Zero cases as selected value, not 0

EDIT:

@AureliaRoumesy, I've fixed it in my fork. Don't know why you need displayLabel. Ordinary labels work just fine for me. Please, check my latest commit of my fork: https://github.com/xvonabur/react-native-material-dropdown/commit/55e70d0d749eefacd2ada84c6adbcef10a3f4116

chriscom2019 commented 4 years ago

I'm using this component in one of my projects. How do apply changes to my project?