n4kz / react-native-pages

Easy to use page view component
Other
376 stars 83 forks source link

Vertical Scroll/Pagination on Layout changes results in wrong scroll position #9

Closed Secretmapper closed 7 years ago

Secretmapper commented 7 years ago

How to reproduce:

Create a multi paged, vertical layout. When switching from landscape to portrait and vice versa, the scroll position would sometimes end up 'in the middle' so to speak.

Furthermore, if a layout change is triggered by say the keyboard (text input inside pager), it would also result in the wrong scroll position.

n4kz commented 7 years ago

Thanks for reporting! Fixed in 0.5.2. Looks like problem was caused by unwanted onScroll event, produced by native ScrollView implementations during layout updates.

Secretmapper commented 7 years ago

Thanks for the quick turn around @n4kz! I just tested it and it works as far as I tested :)