Small transparent chin below the titlebar if window is shaded

n4n0GH / hello

the complete KDE theme

218 stars 26 forks source link

Small transparent chin below the titlebar if window is shaded #1

Closed Schlaefer closed 4 years ago

Schlaefer commented 5 years ago

Every shaded windows shows a little chin below the titlebar:

Screenshot_20191110_155338

on 3651b35 KDE Plasma Version: 5.17.2 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1 Kernel Version: 5.3.8

n4n0GH commented 5 years ago

Confirmed. I actually already had that listed in the source code as an issue, forgot to open one here. Thanks.

n4n0GH commented 4 years ago

Note to self: render error changes size when titlebar uses different height settings.

shadow_error

n4n0GH commented 4 years ago

This glitch only occurs if shadow sizes "Large" and "Very Large" are used. Now I know when it happens, let's fix this shit!

arun54321 commented 4 years ago

I getting that bug even with medium sized shadows.

n4n0GH commented 4 years ago

What other settings are you using?

arun54321 commented 4 years ago

https://allthepics.net/images/Screenshot_20191129_120840.jpg

shadow: medium, strength 86%, color - black. no custom rule for dolphin

n4n0GH commented 4 years ago

Interesting. The screenshot size is also your screen's resolution?

arun54321 commented 4 years ago

Interesting. The screenshot size is also your screen's resolution?

No. It's a cropped screenshot. The screen resolution is 1920x1080.

arun54321 commented 4 years ago

The latest update fixed the bottom chin like bug but it introduced an artifact.

n4n0GH commented 4 years ago

Yes I pushed a work in progress. Consider the repo bleeding edge, only the releases are stable.

n4n0GH commented 4 years ago

So finally got around to work on this piece of shiet. The glitch is now gone, however a shadow will appear a bit offset to the bottom. This is however a much better look than what we had before so @arun54321 if you want you can pull the repo and recompile the theme to get much better looking shaded windows now. I'm working on fixing the offset tonight.

arun54321 commented 4 years ago

Looks good to me.