search

n4n0GH / hello

the complete KDE theme
218 stars 26 forks source link

Removed rounding corners when no decoration on window is present. #29

Closed Acemond closed 4 years ago

Acemond commented 4 years ago

This addition will remove the rounding of the corners for all windows that don't have a decoration.

Acemond commented 4 years ago

Just noticed you already tried that option. What did go wrong with it?

n4n0GH commented 4 years ago

I think if you just use the detector for decorations, you'll remove the support to give applications that use CSD rounded corners. 

Try your patch with Firefox and remove its titlebar. 

  1. Nov. 2019, 14:42 von notifications@github.com:

Just noticed you already tried that option. What did go wrong with it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, > view it on GitHub https://github.com/n4n0GH/hello/pull/29?email_source=notifications&email_token=AGRD6UD5DG2HGNTNZTKQHQLQVZ2K7A5CNFSM4JSG2QMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJRDQQ#issuecomment-559092162> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AGRD6UHCEBQGGTPPZ7WQ7R3QVZ2K7ANCNFSM4JSG2QMA> .

Acemond commented 4 years ago

I see. Well this doesn't impact me, so for now I'll continue with this branch. If I find a better solution I'll push it. You can delete this PR.

n4n0GH commented 4 years ago

Afaik the only way to get this working correctly is by using the logic we already discussed in #17