search

n4n0GH / hello

the complete KDE theme
219 stars 26 forks source link

[BUG] outline does not extend to corners when borders set to "none" #39

Closed ripefig closed 4 years ago

ripefig commented 4 years ago

image

This bug is present in KDE's Breeze theme as well.

n4n0GH commented 4 years ago

This is appearing while using border radius and no borders and no hello shaders, correct?

ripefig commented 4 years ago

this is with no borders.

n4n0GH commented 4 years ago

Uh, yes. But you're also using border radius and not using the hello shaders, right?

ripefig commented 4 years ago

Ah yes, I didn't see the shaders were an option. I've installed them and it looks good - fixes the issue.

ripefig commented 4 years ago

Sorry, didn't mean to close this.

n4n0GH commented 4 years ago

Yeah so the reasoning behind this is that the theme itself is expecting borders. At least on the top and bottom to draw the rounded corners. I actually need to set this up as the "theme suggested border setting". Anyway, when using no borders, the theme still tries to calculate shadows as if it would find rounded corners at the bottom. I could make it so it doesn't look for borders like that, but this is kinda a macOS inspired theme and macOS has rounded corners everywhere. Maybe for the next project. If everything worked for you, you are free to close the issue, no worries.