search

n4r1b / ferrisetw

Basically a KrabsETW rip-off written in Rust
Other
62 stars 20 forks source link

Schema::properties() isn't public #128

Open vvuk opened 4 months ago

vvuk commented 4 months ago

Schema::properties() is currently pub(crate), but is there any reason it shouldn't be just pub? It's very useful for being able to inspect the properties in a schema; I couldn't find any other way of getting this list.

n4r1b commented 4 months ago

The properties were meant to be tied to the Parser so ideally you would use the Parser instance to access them. I'm not opposed to making this Schema::properties() if there're a good use case for this, or we could extend the Schema to cover this cases without directly exposing the properties. Let me know what you prefer @vvuk! Could you also give me some examples on use cases where you want to inspect the properties :)