n4r1b / ferrisetw

Basically a KrabsETW rip-off written in Rust
Other
65 stars 24 forks source link

Reviewed visibility #70

Closed daladim closed 1 year ago

daladim commented 2 years ago

This PR depends on #63 , #65 , #66 and #68 (it does not depend on all of them feature-wise, but merging them first will avoid git conflicts, especially in the use ....; lines at the beginning of files)

This PR (or rather, its last 5 commits) reviews the visibility of many types and modules, so that the user-facing API and documentation only exposes what he will need.

Maybe(?) some issues were pre-existing, but I think most of these too-widly-visible items were due to uncautious refactos of mine

daladim commented 2 years ago

Build is failing. I probably did not include all the dependant commits after all. I'll rebase after other PR (the ones that are passing) are merged, that will be easier to rebase.

You can consider this PR as a draft for the moment

daladim commented 2 years ago

I've rebased so that it now compiles and passes the tests.

I've also added a commit that removes unused error types.