search

n4ze3m / page-assist

Use your locally running AI models to assist you in your web browsing
https://chromewebstore.google.com/detail/page-assist-a-web-ui-for/jfgfiigpkhlkbnfnbobbkinehhfdhndo
MIT License
1.56k stars 148 forks source link

App stalls/hangs #246

Open HarrievG opened 1 week ago

HarrievG commented 1 week ago

Running latest edge Version 130.0.2849.80 (Official build) (64-bit) and latest page-assist Version: 1 . 3 . 3

This has been an issue from the start. Every couple of seconds it hangs for a second. No other webpage or app/extension in the edge browser is doing this.

After inspecting the logs it seems to coincide with the /api/tags update.

2024/11/11 - 13:29:28 | 200 | 2.6771ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:29:50 | 200 | 2.2569ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:30:14 | 200 | 3.7969ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:30:38 | 200 | 2.4413ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:31:02 | 200 | 2.8498ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:31:24 | 200 | 2.8495ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:31:48 | 200 | 2.8618ms | 127.0.0.1 | GET "/api/tags" 2024/11/11 - 13:32:12 | 200 | 2.0998ms | 127.0.0.1 | GET "/api/tags"

Why are these polls actually needed every 23 sec? Its even polling while you are not using the model dropdown or even when the browser tab is not active?

The stall is disruptive and annoying.

Let me know if you need any more info to pinpoint and solve this.

n4ze3m commented 1 week ago

Hey, sorry about the issue. I added it in the first version without knowing it would cause problems. I'll remove it in the upcoming update (1.3.5) this weekend.

HarrievG commented 1 week ago

After update I will confirm and close bug right away.

Thanks a lot!

HarrievG commented 2 days ago

This has gotten worse since I added 2 new models, it is totally unusable now. :"(

I tried to profile it to get some impression where this is actually coming from. In a 17 second trace made with the devtools in Edge, there is a total of 8 seconds of "Minor GC" .

This trace was captured without ollama running, so im not sure if this is all going to be solved by your change in ollama.ts.

When are you going to release 1.3.5? Do you have any idea what is causing this?

n4ze3m commented 2 days ago

Needs a few more tests before release. It's currently in draft but will be ready soon. :)